Ksagiyam/submesh core #3478
Draft
Ksagiyam/submesh core #3478
+160,787
−568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksagiyam
force-pushed
the
ksagiyam/submesh_core
branch
3 times, most recently
from
9b8f70c to
1e7c035
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core
branch
10 times, most recently
from
219240f to
d555615
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core
branch
2 times, most recently
from
9b1d48b to
23caf2e
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core
branch
7 times, most recently
from
f5afedb to
824f2a5
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core
branch
2 times, most recently
from
76e89ef to
7e3c248
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core
branch
from
b6a41e7 to
9c839e0
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core
branch
2 times, most recently
from
1167181 to
fc6545c
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core
branch
from
a76cca5 to
630bfb4
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core
branch
from
2fe02f9 to
8ba65d6
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core
branch
from
e204069 to
b8cc6f6
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core
branch
2 times, most recently
from
a683850 to
ed0e3b1
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core
branch
from
8417b41 to
71a75aa
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core
branch
5 times, most recently
from
4958817 to
7cda1d3
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core
branch
from
59a3735 to
1a10b35
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core
branch
2 times, most recently
from
4174e56 to
da2063b
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core
branch
from
da2063b to
1b654c1
Compare
pbrubeck
reviewed
Dec 22, 2024
Comment on lines
+288
to
+290
| # This way of caching is fragile. | ||
| # Should Implement _hash_key_() for ModifiedTerminal and use the entire mt as key. | ||
| return (ufl_element, mt.local_derivatives, ctx.point_set, ctx.integration_dim, entity_id, coordinate_element, mt.restriction, domain._ufl_hash_data_()) |
There was a problem hiding this comment.
I believe this key should not depend on the mesh. We just need to call finat once, independently of mt.terminal (and its domain).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable cell submesh.
Depends on:
UFL